Skip to content

Wont fix feature - #1224

Merged
riosje merged 1 commit into
mainfrom
jeff/addwontfixfeat
Jul 21, 2026
Merged

Wont fix feature#1224
riosje merged 1 commit into
mainfrom
jeff/addwontfixfeat

Conversation

@riosje

@riosje riosje commented Jul 20, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved reconciliation accuracy by ensuring all closed, stream-labeled issues are retrieved.
    • Prevented incomplete “won’t fix” suppression results when many closed issues exist.
    • Excluded pull requests from closed-issue results.

@riosje
add wont fix feature
c135526 
Signed-off-by: Jefferson <jefferson.rios.caro@gmail.com>
@riosje
riosje force-pushed the jeff/addwontfixfeat branch from d0fe43b to c135526 Compare July 20, 2026 15:01
@coderabbitai

coderabbitai Bot commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Gh.list_closed_issues now retrieves all closed stream-labeled issues through the paginated GitHub REST API, excludes pull requests, and parses the complete response into the reconciliation suppression set.

Changes

Closed issue retrieval

Layer / File(s) Summary
Paginated closed-issue fetch
dep_checker/reconcile_issues.py		 Gh.list_closed_issues removes the limit parameter, uses gh api --paginate, parses line-delimited JSON results, and excludes pull requests.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Poem

A rabbit hops through pages wide,
No closed issue left outside.
Pull requests fade from the trail,
Complete suppression sets prevail.
“Hop hop!” says Bun, “the fetch won’t fail!”

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is related to the change because the PR updates the won't-fix reconciliation behavior, though it is broad.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jeff/addwontfixfeat

Comment @coderabbitai help to get the list of available commands.

@riosje
riosje merged commit a555bd2 into main Jul 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@riosje